Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minio support ? #49

Closed
gedw99 opened this issue May 25, 2021 · 1 comment
Closed

minio support ? #49

gedw99 opened this issue May 25, 2021 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers high-priority

Comments

@gedw99
Copy link

gedw99 commented May 25, 2021

current code looks very aws centric. What about minio support for those that dont want to be tied to a cloud provider ?
@gedw99 gedw99 added the enhancement New feature or request label May 25, 2021
@fulmicoton
Copy link
Contributor

We have already isolated the storage abstraction to this
https://github.com/quickwit-inc/quickwit/blob/main/quickwit-storage/src/storage.rs#L77-L100

Granted we only have a filesystem and an Amazon S3 implementation, but supporting other storage should be easy.

@fmassot fmassot added the good first issue Good for newcomers label Nov 29, 2021
@fmassot fmassot pinned this issue Nov 29, 2021
@fulmicoton fulmicoton mentioned this issue Jan 13, 2022
Closed
4 tasks
fulmicoton added a commit that referenced this issue Jan 14, 2022
@fulmicoton
Adds support for custom s3 endpoint.
d599544 
This removes our trickery to use localstack,
and replaces it by a way to set a specific
endpoint via an environment variable:
`QW_S3_REGION`.

Closes #49
Closes #1037
@fmassot fmassot unpinned this issue Jan 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers high-priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fmassot @fulmicoton @gedw99