Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added PhraseMatchQuery and MultiMatchQuery. #3727

Merged
merged 2 commits into from
Aug 11, 2023
Merged

Added PhraseMatchQuery and MultiMatchQuery. #3727

merged 2 commits into from
Aug 11, 2023

Conversation

fulmicoton
Copy link
Contributor

Closes #3725

@fulmicoton fulmicoton marked this pull request as ready for review August 9, 2023 08:04
@fulmicoton fulmicoton force-pushed the issue/3725-multimatch-query branch 3 times, most recently from b6fec2f to abce793 Compare August 9, 2023 08:21
trinity-1686a
trinity-1686a reviewed Aug 9, 2023
View reviewed changes
Copy link
Contributor

@trinity-1686a trinity-1686a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see per-field boosting and wildcard fields. I don't know if we want to support them, if we don't, we should probably return an explicit error when getting one of those

@fulmicoton
Copy link
Contributor Author

per-field boosting and wildcard fields

I added code to return an error in that case.

@fulmicoton fulmicoton merged commit f9f9114 into main Aug 11, 2023
3 checks passed
@fulmicoton fulmicoton deleted the issue/3725-multimatch-query branch August 11, 2023 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trinity-1686a trinity-1686a trinity-1686a approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for ES multimatch query
2 participants
@fulmicoton @trinity-1686a