-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add api endpoint to get query ast #5212
Conversation
quickwit_ast: request_metadata.query_ast_resolved, | ||
tantivy_ast: format!("{query:#?}"), | ||
searched_splits: split_ids, | ||
storage_requests: StorageRequestCount { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's cool you extended the thing to a warmup info etc! can we actually get the number of bytes as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's something i would find interesting too, but right now it's not as easy to get. All metadata we get here, we get only through the metastore, with zero call to the storage. To get more, we would need to actually download things from storage, which starts having more of a EXPLAIN ANALYSE
than an EXPLAIN
semantic. I think that should be left out of scope of this PR, but let's open a ticket so eventually people can pass ?analyze=true
or something to get that information as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comments inline.
6c17624
to
c750349
Compare
Description
fix #5190
add api endpoint to get the quickwit and tantivy ast for a query, as well as what splits would be hit (taking into account time range and tags), and how many/what kind of storage request are to be expected for each split
How was this PR tested?
tested manually plus added basic unit test