Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add error handling for invalid CustomOrder in term aggregation #2435

Closed
PSeitz opened this issue Jun 13, 2024 · 0 comments · Fixed by #2451
Closed

Add error handling for invalid CustomOrder in term aggregation #2435

PSeitz opened this issue Jun 13, 2024 · 0 comments · Fixed by #2451

Comments

@PSeitz
Copy link
Contributor

PSeitz commented Jun 13, 2024

We should fail if order contains more than one key

"order": {
      "avg_field": "desc",
      "_key": "desc"
}

or is an array with more than one entry, which is not supported currently

"order": [ { "avg_field": "desc" }, { "_key":"desc" } ]

quickwit-oss/quickwit#5120
PSeitz added a commit that referenced this issue Jul 9, 2024
@PSeitz
extend custom order deserialization
617501a 
allow arrays
improve validation
closes #2435
@PSeitz PSeitz mentioned this issue Jul 9, 2024
Merged
PSeitz added a commit that referenced this issue Jul 10, 2024
@PSeitz
extend custom order deserialization
2d55bc8 
allow arrays
improve validation
closes #2435
PSeitz added a commit that referenced this issue Jul 30, 2024
@PSeitz
extend custom order deserialization (#2451)
75dc3eb 
allow arrays
improve validation
closes #2435
philippemnoel pushed a commit to paradedb/tantivy that referenced this issue Aug 31, 2024
@PSeitz @philippemnoel
extend custom order deserialization (quickwit-oss#2451)
c8cf891 
allow arrays
improve validation
closes quickwit-oss#2435
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

extend custom order deserialization quickwit-oss/tantivy
1 participant
@PSeitz