Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix is_child_of function not considering the root facet. #2086

Merged
merged 1 commit into from
Jun 12, 2023
Merged

Fix is_child_of function not considering the root facet. #2086

merged 1 commit into from
Jun 12, 2023

Conversation

adamreichold
Copy link
Collaborator

I think this is basically the same issue as #1448 at another place in the code base.

Closes #2085

@codecov-commenter
Copy link

Codecov Report

Merging #2086 (be9d06d) into main (e3eacb4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main    #2086   +/-   ##
=======================================
  Coverage   94.39%   94.40%           
=======================================
  Files         321      321           
  Lines       60386    60412   +26     
=======================================
+ Hits        57003    57031   +28     
+ Misses       3383     3381    -2     
Impacted Files Coverage Δ
src/collector/facet_collector.rs 98.90% <100.00%> (+0.37%) ⬆️

@PSeitz PSeitz merged commit 3a82ef2 into quickwit-oss:main Jun 12, 2023
@adamreichold adamreichold deleted the fix-facet-collector branch June 12, 2023 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot collect facets starting from the root in Tantivy 0.20
3 participants