Feature/clipboard sync #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
gtluszcz
commented
Oct 3, 2018
gtluszcz
commented
- Replacing text is now made with synchronous clipboard replacements so that we can be sure that they are executed in order
- Any error with clipboard will be indicated with notification (if possible)
DCzajkowski
requested changes
Oct 3, 2018
src/main/modules/SnippetsManager.js
Outdated
| @@ -2,18 +2,18 @@ const chars = require('./chars') | |||
| const NativeKeymap = require('native-keymap') | |||
| const _ = require('lodash') | |||
| const Notification = require('./Notification') | |||
| const clipboardy = require('clipboardy') | |||
There was a problem hiding this comment.
This dependency should be injected via the constructor to preserve testability.
src/main/modules/SnippetsManager.js
Outdated
| @@ -188,12 +188,31 @@ class SnippetsManager { | |||
| } | |||
|
|
|||
| replace(value) { | |||
| const clipboardContent = this.clipboard.readText() | |||
| try { | |||
| // 1. store old clipboard data | |||
There was a problem hiding this comment.
I don't think comments are necessary nor are adding any value. Let's write code that doesn't require comments ;)
src/main/modules/SnippetsManager.js
Outdated
| this.keyboardSimulator.keyTap('v', 'command') | ||
| // 4. place stored data back in clipboard | ||
| setTimeout(() => clipboardy.writeSync(clipboardContent), 50) | ||
| return true |
There was a problem hiding this comment.
Returning a boolean may be a nice thing to do, but we are not using this returned information nowhere, so I don't see any value.
houndci-bot
reviewed
Oct 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.