-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Varints for numeric transport parameters #1608
Comments
The TLS presentation language doesn't currently support varints. I suppose one could add it as a feature. |
SGTM. |
I think that it makes sense to use varints for representing the values of the TransportParameters (i.e. the values defined in section 6.6.1 Transport Parameter Definitions). I do not oppose to using varint for TransportParameterId. OTOH, (I do not necessarily assume that you meant this, but) I would oppose to using varints for QuicVersion, or using varint for representing the size of the blocks (i.e. the length of the block represented using |
That's exactly what I meant. Thanks for clarifying. |
Discussed in NYC; @marten-seemann to drive to a conclusion by 15/10. |
It's 10/16, any updates @marten-seemann |
@ianswett: Sorry for the delay. Just sent out a mail to the list. |
This is a partial change related to #1608. It builds on the renumbering of transport parameters so as to avoid churn.
Fixed by #1947. |
Using varints instead of fixed size fields would allow us to save bytes in the common case, while allowing for a wider range of values if needed. Most importantly, we'd be more consistent in how we encode values across the protocol.
I'm not sure how to correctly write that in the TLS presentation language though.
The text was updated successfully, but these errors were encountered: