Optional Idle Timeout #1765
Optional Idle Timeout #1765
Conversation
|
Would it make sense to use varint to allow timeouts longer than 18 hours (e.g. 1 day)? |
draft-ietf-quic-transport.md
Outdated
|
|
||
| : The idle timeout is a value in seconds that is encoded as an unsigned 16-bit | ||
| integer. There is no maximum value besides the maximum encodable value of | ||
| 0xFFFF (about 18 hours). If this parameter is abset or zero then the idle |
|
Personally, I'd prefer not to use variable length integers here, but either way, I think we should leave that discussion to #1608 and not make that change as part of this PR. If you want an explicit idle timeout larger than 18 hours, then we should make this a 4-byte value instead of 2. |
draft-ietf-quic-transport.md
Outdated
| @@ -1666,6 +1654,18 @@ ack_delay_exponent (0x0007): | |||
| value is also used for ACK frames that are sent in Initial and Handshake | |||
| packets. Values above 20 are invalid. | |||
|
|
|||
| initial_max_uni_streams (0x0008): | |||
There was a problem hiding this comment.
Please don't move this. The numbers are all out of order, but I do hope to fix that eventually.
| A connection that remains idle for longer than the advertised idle timeout (see | ||
| {{transport-parameter-definitions}}) is closed. A connection enters the | ||
| draining state when the idle timeout expires. | ||
| If the idle timeout is enabled, a connection that remains idle for longer than |
There was a problem hiding this comment.
This change isn't needed. There is always an idle timeout, it's just that it is sometimes infinite.
There was a problem hiding this comment.
We didn't quite state it that way above. It says the idle timeout is disabled, not infinite.
draft-ietf-quic-transport.md
Outdated
| server. | ||
| : The idle timeout is a value in seconds that is encoded as an unsigned 16-bit | ||
| integer. There is no maximum value besides the maximum encodable value of | ||
| 0xFFFF (about 18 hours). If this parameter is absent or zero then the idle |
There was a problem hiding this comment.
I wouldn't bother with the maximum sentence thing.
draft-ietf-quic-transport.md
Outdated
| integer. There is no maximum value besides the maximum encodable value of | ||
| 0xFFFF (about 18 hours). If this parameter is absent or zero then the idle | ||
| timeout is disabled. In this case, the transport never closes the connection | ||
| in response to being idle. |
There was a problem hiding this comment.
drop this last sentence too
martinthomson
added
design
|
Thanks |
Ns 1520 and 1521 refer to artefacts in lucas-clemente/quic-go GitHub repository.
…-15-changelog Fix ID-15 changelog: idle timeout was made optional by PR #1765
Idle timeout is currently the last required transport parameter. This makes the parameter optional, defaulting to 0 or disabled if not present. It also removes the 10 minute maximum value. For other non-http protocols over QUIC, a 10 minute max doesn't really make sense.