Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closing/draining redundancies #3907

Closed
martinthomson opened this issue Jul 14, 2020 · 0 comments · Fixed by #3988
Closed

Closing/draining redundancies #3907

martinthomson opened this issue Jul 14, 2020 · 0 comments · Fixed by #3988
Labels
-transport editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
Late Stage Processing

Comments

@martinthomson
Copy link
Member

The section on Immediate Close contains some text that is redundant with the section on the Closing and Draining periods. Factor some of this out.
@martinthomson martinthomson added editorial An issue that does not affect the design of the protocol; does not require consensus. -transport post-wglc labels Jul 14, 2020
@martinthomson martinthomson mentioned this issue Jul 14, 2020
Merged
@LPardue LPardue added this to Editorial Issues in Late Stage Processing Jul 14, 2020
martinthomson added a commit that referenced this issue Aug 6, 2020
@martinthomson
Closing and draining tidy
45e033d 
I took a careful look at the text here and found a few things:

1. There wasn't much redundancy, but there was a little.

2. The closing and draining states only apply to immediate close.

So I moved things up.  Shortened the top-level immediate close text, and
moved text specific to closing or draining to the corresponding
sections.

There were a few bits that could be cut, and a few that needed to be
better aligned with existing text, but nothing major.  Most of this is
unmodified text.

There are a few bits that I had to rewrite.  I will add comments for
those.

Closes #3907.
@martinthomson martinthomson mentioned this issue Aug 6, 2020
Merged
Late Stage Processing automation moved this from Editorial Issues to Issue Handled Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
-transport editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
Late Stage Processing
  
Issue Handled
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Closing and draining tidy quicwg/base-drafts
1 participant
@martinthomson