Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instructions that use "Without Name Reference" #4137

Closed
martinthomson opened this issue Sep 23, 2020 · 0 comments · Fixed by #4163
Closed

Instructions that use "Without Name Reference" #4137

martinthomson opened this issue Sep 23, 2020 · 0 comments · Fixed by #4163
Labels
-qpack editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
Late Stage Processing

Comments

@martinthomson
Copy link
Member

martinthomson commented Sep 23, 2020 •
edited
Loading

Without Name Reference might be better replaced as "With Literal Name"

(Damn my enter key...)
@martinthomson martinthomson changed the title Instructions that use without name reference Instructions that use "Without Name Reference" Sep 23, 2020
@martinthomson martinthomson added -qpack editorial An issue that does not affect the design of the protocol; does not require consensus. labels Sep 23, 2020
@larseggert larseggert added this to Triage in Late Stage Processing via automation Sep 23, 2020
martinthomson added a commit that referenced this issue Sep 24, 2020
@martinthomson
"With Literal Name" instead of "Without Name Reference"
58fdbce 
This saves bytes (that's the most important reason).

This uses something positive rather than something negative to define
the instruction.

Yes, it means that there are two "Literal"s in the name of an
instruction.  But now it says what is inside rather than what isn't.

Closes #4137.
@martinthomson martinthomson mentioned this issue Sep 24, 2020
Merged
Late Stage Processing automation moved this from Triage to Issue Handled Sep 24, 2020
afrind added a commit that referenced this issue Sep 24, 2020
@martinthomson @MikeBishop @afrind
"With Literal Name" instead of "Without Name Reference" (#4163)
6728201 
* "With Literal Name" instead of "Without Name Reference"

This saves bytes (that's the most important reason).

This uses something positive rather than something negative to define
the instruction.

Yes, it means that there are two "Literal"s in the name of an
instruction.  But now it says what is inside rather than what isn't.

Closes #4137.

* missed one

damned capitalization inconsistency

Co-authored-by: Mike Bishop <mbishop@evequefou.be>

* Update draft-ietf-quic-qpack.md

Update example

Co-authored-by: Mike Bishop <mbishop@evequefou.be>
Co-authored-by: afrind <afrind@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
-qpack editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
Late Stage Processing
  
Issue Handled
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

"With Literal Name" instead of "Without Name Reference" quicwg/base-drafts
1 participant
@martinthomson