New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"With Literal Name" instead of "Without Name Reference" #4163
Conversation
This saves bytes (that's the most important reason). This uses something positive rather than something negative to define the instruction. Yes, it means that there are two "Literal"s in the name of an instruction. But now it says what is inside rather than what isn't. Closes #4137.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also consider changing on line 1640, but GitHub won't let me comment that far from a change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like a sensible change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is an improvement.
It has always bothered me that "literal field line" is used in sitations when only part of the field line is literal, and this change does not address that. An alternative would be:
insert with literal name => insert literal field line (or literal entry)
literal field line with name reference => field line with name reference and literal value
literal field line with literal name => literal field line
damned capitalization inconsistency Co-authored-by: Mike Bishop <mbishop@evequefou.be>
@bencebeky I can't solve all the problems :) I think that in HPACK "literal" was reserved for the value more than the name. Maybe this only highlights that... |
Update example
I understand. This commit at least solves some of them, thank you for the improvement! |
Beauty is in the eye of the beholder. What am I to do with all the "wonr" variable names? |
This saves bytes (that's the most important reason).
This uses something positive rather than something negative to define
the instruction.
Yes, it means that there are two "Literal"s in the name of an
instruction. But now it says what is inside rather than what isn't.
Closes #4137.