Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect reference to stream state section from frame description #4832

Closed
tfpauly opened this issue Mar 8, 2021 · 0 comments · Fixed by #4852
Closed

Incorrect reference to stream state section from frame description #4832

tfpauly opened this issue Mar 8, 2021 · 0 comments · Fixed by #4852
Labels
-transport editorial An issue that does not affect the design of the protocol; does not require consensus.

Comments

@tfpauly
Copy link

tfpauly commented Mar 8, 2021

Very editorial nit:

The STOP_SENDING Frames section has the following text:

A STOP_SENDING frame can be sent for streams in the Recv or Size Known states; see {{stream-send-states}}.

The states referenced here are in fact receive stream states, not send stream states. Should this be:

A STOP_SENDING frame can be sent for streams in the Recv or Size Known states; see {{stream-recv-states}}.

The same goes for MAX_STREAM_DATA:

A MAX_STREAM_DATA frame can be sent for streams in the Recv state; see {{stream-send-states}}.
@LPardue LPardue added the editorial An issue that does not affect the design of the protocol; does not require consensus. label Mar 13, 2021
martinthomson added a commit that referenced this issue Mar 24, 2021
@martinthomson
Cite receive stream section for receipt of MAX_*
e9c1a12 
Tommy points out that we accidentally cited the sending parts, but these
are receive states.

Closes #4832.
@martinthomson martinthomson mentioned this issue Mar 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
-transport editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cite receive stream section for receipt of MAX_* quicwg/base-drafts
3 participants
@larseggert @tfpauly @LPardue