New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reference RFC5681 and RFC6928 #1245
Merged
Merged
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
672a0b7
Reference RFC6928
ianswett 1099e08
Reference RFC5681
ianswett bdd2bfe
Update pseudocode
ianswett 4c362b7
Merge branch 'master' into ianswett-rfc6928
ianswett 437b60b
Update draft-ietf-quic-recovery.md
ianswett 2b5af83
max_datagram_size
ianswett dcfb306
kMaxDatagramSize
ianswett a89af60
Update draft-ietf-quic-recovery.md
ianswett a660cfd
Update draft-ietf-quic-recovery.md
ianswett e547658
Update draft-ietf-quic-recovery.md
ianswett b96762e
Update draft-ietf-quic-recovery.md
ianswett 9570a81
Update draft-ietf-quic-recovery.md
ianswett File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would note that RFC 6928 states the following as the TCP initial window:
More precisely, the upper bound for the initial window will be
I would recommend that one do calculate this value for the Initial value, as MSS may be based on a 9K MTU, thus allowing two full packets in those cases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also if mss is smaller than 1460 then more than 10 packets can be sent. Is that intentional? I am slightly worried about packet bursts. Are there a pacing requirement?