Various spin-exp nits #1290
Merged
Various spin-exp nits #1290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinthomson
approved these changes
Apr 12, 2018
ihlar
reviewed
Apr 17, 2018
| using the fifth most significant bit (0x08) of the first octet in the short | ||
| header for the spin bit. | ||
| As of the current editor's version of {{QUIC-TRANSPORT}}, this proposal | ||
| specifies using the fifth most significant bit (0x08) of the first octet in |
There was a problem hiding this comment.
There's a mismatch with the figure (and the transport draft) here that specifies the sixth most significant bit (0x04) for the spin purpose.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes suggested by @martinthomson in #1286 and by @acmacm in the other repo, modulo those already covered in #1288