-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add draft-ietf-quic-spin-exp #1286
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks pretty good I have a bunch of nits and cleanup notes, but I don't think that those need to be addressed before merging.
stored value when a packet with a short header is sent out. The spin value is | ||
initialized to 0 on both side, at the client as well as the server at | ||
connection start. Each endpoint also remembers the highest packet number seen | ||
from its peer on the connection. The spin value is then determined at each |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd break a new paragraph after this period.
from its peer on the connection. The spin value is then determined at each | ||
endpoint as follows: | ||
|
||
* When it receives a packet from the client, if that packet has a short header |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"it" here could be "server" and then the next "by the server" can be removed. Same below.
## Resetting Spin Value State | ||
|
||
Each client and server resets it spin value to zero when sending the first | ||
packet in a given with a new Connection ID. This reduces the risk that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/in a given/ I think that we have stopped German-casing "connection ID" as well.
across an edge, which would lead to low RTT estimates, if not ignored. | ||
|
||
The packet number can be used to filter out high RTT estimates due to loss of | ||
an actual edge in a burst of lost packets. If the spin bit edge occurs after a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are two different concepts and might benefit from being separated better (by the appropriate joining word, or by putting them in different paragraphs).
|
||
However, application-limited and flow-control-limited senders can have | ||
application and transport layer delay, respectively, that are much greater | ||
than network RTT. When the sender is application-limited and e.g. only sends |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"For example, when a sender spends time on processing or other tasks, the value measured using the spin bit includes that time in addition to the network RTT."
spin signal, which provides reordering, loss, and edge delay resistance even | ||
without cleartext packet numbers in the QUIC header, is described in | ||
{{?QUIC-SPIN=I-D.trammell-quic-spin}}; experimentation with this approach is | ||
also encouraged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure that we want to drag more bits into this.
title: The QUIC Latency Spin Bit | ||
abbrev: QUIC Spin Bit | ||
docname: draft-ietf-quic-spin-exp-latest | ||
date: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note for fixup, use {DATE}
.
|
||
# Introduction | ||
|
||
The QUIC transport protocol {{?QUIC-TRANS=I-D.ietf-quic-transport}} uses |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note for fixup: use definition of -transport citation from other drafts.
## About This Document | ||
|
||
This document is maintained in the GitHub repository | ||
https://github.com/britram/draft-trammell-quic-spin, and the editor's copy is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note for fixup: point to new location.
|
||
The spin bit is intended to expose end-to-end RTT to observers along the path, | ||
so the privacy considerations for the latency spin bit are essentially the | ||
same as those for passive RTT measurement in general. However, it has been |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any work that could be cited here?
This adds draft-ietf-quic-spin-exp-00, describing the spin bit, to the base-drafts repository.