Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exception in ECN detection when ACK loss happens #1555

Merged
merged 7 commits into from
Jul 14, 2018
Merged

Exception in ECN detection when ACK loss happens #1555

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5f0d7b1
Merge tag 'draft-ietf-quic-transport-13' of https://github.com/quicwg…
gloinul Jul 12, 2018
d5729ff
Adding exception due to ack loss.
gloinul Jul 12, 2018
1d37a4c
Fixing trailing spaces.
gloinul Jul 12, 2018
261c0e7
Implementing Ian's proposals
gloinul Jul 12, 2018
03ddb3e
Addressing editorial from Ian
gloinul Jul 13, 2018
7687a00
Fixing spelling of comparisons
gloinul Jul 13, 2018
2a32722
Removed extra empty line.
gloinul Jul 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions draft-ietf-quic-transport.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1739,6 +1739,14 @@ network, an endpoint verifies the following when an ACK_ECN frame is received:
* The increase in ECT(0) and ECT(1) counters MUST be no greater than the number
of packets newly acknowledged that were sent with the corresponding codepoint.

* If the increase in the ECT(0), ECT(1) and CE counters are greater than
the number of newly acknowledged packets, and the received ACK's
smallest acknowledged is larger than the previous largest acknowledged,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I pointed out, this isn't ideal and will lead to ECN being disabled in some cases. I don't know how much we are going to want to worry about that though.

then it's likely acknowledgements were missed, and the above comparison
MUST NOT be performed. Instead a new comparison point is stored by the
sender so that only changes after this point will be used in the future
comparisons.

Upon successful verification, an endpoint continues to set ECT codepoints in
subsequent packets with the expectation that the path is ECN-capable.

Expand Down