Exception in ECN detection when ACK loss happens #1555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/base-drafts into ecn-ack-loss Tag for draft-ietf-quic-transport-13 created by Martin Thomson
ianswett
reviewed
Jul 12, 2018
draft-ietf-quic-transport.md
Outdated
| @@ -1738,6 +1738,14 @@ network, an endpoint verifies the following when an ACK_ECN frame is received: | |||
|
|
|||
| * The increase in ECT(0) and ECT(1) counters MUST be no greater than the number | |||
| of packets newly acknowledged that were sent with the corresponding codepoint. | |||
|
|
|||
| * If the increase in the ECT(0), ECT(1) and CE counters are greater than the | |||
| number of newly ACKed packets, and received ACK's smallest acknowledged or | |||
There was a problem hiding this comment.
I would just say "ACK's smallest acknowledged" and drop "or gap indicated packet number"
draft-ietf-quic-transport.md
Outdated
|
|
||
| * If the increase in the ECT(0), ECT(1) and CE counters are greater than the | ||
| number of newly ACKed packets, and received ACK's smallest acknowledged or | ||
| gap indicated packet number is larger than previously largest acknowledged |
There was a problem hiding this comment.
How about: "...larger than the previous largest acknowledged, then it's likely acknowledgements were missed, and the above comparison MUST NOT be performed."
ianswett
reviewed
Jul 13, 2018
draft-ietf-quic-transport.md
Outdated
| @@ -1739,6 +1739,13 @@ network, an endpoint verifies the following when an ACK_ECN frame is received: | |||
| * The increase in ECT(0) and ECT(1) counters MUST be no greater than the number | |||
| of packets newly acknowledged that were sent with the corresponding codepoint. | |||
|
|
|||
| * If the increase in the ECT(0), ECT(1) and CE counters are greater than the | |||
| number of newly ACKed packets, and received ACK's smallest acknowledged is | |||
There was a problem hiding this comment.
ACKed -> acknowledged
received -> the received
ianswett
reviewed
Jul 13, 2018
draft-ietf-quic-transport.md
Outdated
| then it's likely acknowledgements were missed, and the above comparison | ||
| MUST NOT be performed. Instead a new comparision point is stored by the | ||
| sender so that only changes after this point will be used in the future | ||
| comaparisions. |
There was a problem hiding this comment.
Mikkel's right, comaparisons -> comparisons
ianswett
approved these changes
Jul 13, 2018
martinthomson
approved these changes
Jul 14, 2018
| @@ -1739,6 +1739,14 @@ network, an endpoint verifies the following when an ACK_ECN frame is received: | |||
| * The increase in ECT(0) and ECT(1) counters MUST be no greater than the number | |||
| of packets newly acknowledged that were sent with the corresponding codepoint. | |||
|
|
|||
| * If the increase in the ECT(0), ECT(1) and CE counters are greater than | |||
| the number of newly acknowledged packets, and the received ACK's | |||
| smallest acknowledged is larger than the previous largest acknowledged, | |||
There was a problem hiding this comment.
As I pointed out, this isn't ideal and will lead to ECN being disabled in some cases. I don't know how much we are going to want to worry about that though.
janaiyengar
approved these changes
Jul 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding an exception to the ECN detection to handle ACK loss if that occurs.
Fixes Issue #1481