Simplify receiver verification of ECN counters #1565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinthomson
approved these changes
Jul 14, 2018
draft-ietf-quic-transport.md
Outdated
| ACK_ECN frame. | ||
|
|
||
| * The increase in ECT(0) and ECT(1) counters MUST be no greater than the number | ||
| * The increase in ECT(0) and ECT(1) counters MUST be no lesser than the number |
There was a problem hiding this comment.
"no lesser" isn't a turn of phrase I'm comfortable with. "MUST be at least the number of newly acknowledged packets"
draft-ietf-quic-transport.md
Outdated
| sender so that only changes after this point will be used in the future | ||
| comparisons. | ||
| * The total increase in ECT(0), ECT(1), and CE counters reported in the ACK_ECN | ||
| frame MUST be no lesser than the total number of packets newly acknowledged in |
ianswett
reviewed
Jul 14, 2018
gloinul
reviewed
Jul 15, 2018
|
I've taken in the suggestion. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mechanism modifies the response proposed in #1555. It isn't perfect, but it's straightforward, and addresses the fragility problem adequately I think.
Fixes #1481.