Use 'encryption' less often #1708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinthomson
added
editorial
ianswett
approved these changes
Aug 28, 2018
MikeBishop
reviewed
Aug 28, 2018
draft-ietf-quic-transport.md
Outdated
| Initial packets. Similarly, Handshake packets can only be sent and | ||
| acknowledged in Handshake packets. | ||
| Conceptually, a packet number space is the context in which a packet can be | ||
| processed and ACKed. Initial packets can only be sent with Initial encryption |
There was a problem hiding this comment.
Should this also be protection?
MikeBishop
reviewed
Aug 28, 2018
draft-ietf-quic-transport.md
Outdated
| Conceptually, a packet number space is the context in which a packet can be | ||
| processed and ACKed. Initial packets can only be sent with Initial encryption | ||
| keys and ACKed in packets which are also Initial packets. Similarly, Handshake | ||
| packets can only be sent and acknowledged in Handshake packets. |
There was a problem hiding this comment.
"Handshake packets can only be sent in Handshake packets" is either tautological or incorrect, and I'm uncertain which. Either way, I don't think this says what you mean to say.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The term is protection in most cases.