Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use 'encryption' less often #1708

Merged
merged 2 commits into from Aug 28, 2018
Merged

Use 'encryption' less often #1708

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e5e2888
Use 'encryption' less often
martinthomson Aug 27, 2018
d016a96
Say things more clearly
martinthomson Aug 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
21 changes: 10 additions & 11 deletions draft-ietf-quic-transport.md
View file
Open in desktop
Expand Up @@ -995,7 +995,7 @@ response to connection migration ({{migration}}). NEW_CONNECTION_ID frames
## Packet Numbers {#packet-numbers}

The packet number is an integer in the range 0 to 2^62-1. The value is used in
determining the cryptographic nonce for packet encryption. Each endpoint
determining the cryptographic nonce for packet protection. Each endpoint
maintains a separate packet number for sending and receiving.

Packet numbers are divided into 3 spaces in QUIC:
Expand All @@ -1005,18 +1005,17 @@ Packet numbers are divided into 3 spaces in QUIC:
- Application data space: All 0-RTT and 1-RTT encrypted packets
{{packet-protected}} are in this space.

As described in {{QUIC-TLS}}, each packet type uses different encryption keys.
As described in {{QUIC-TLS}}, each packet type uses different protection keys.

Conceptually, a packet number space is the encryption context in which
a packet can be processed and ACKed. Initial packets can only be sent
with Initial encryption keys and ACKed in packets which are also
Initial packets. Similarly, Handshake packets can only be sent and
acknowledged in Handshake packets.
Conceptually, a packet number space is the context in which a packet can be
processed and ACKed. Initial packets can only be sent with Initial encryption
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this also be protection?

keys and ACKed in packets which are also Initial packets. Similarly, Handshake
packets can only be sent and acknowledged in Handshake packets.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Handshake packets can only be sent in Handshake packets" is either tautological or incorrect, and I'm uncertain which. Either way, I don't think this says what you mean to say.


This enforces cryptographic separation between the data sent in the
different packet sequence number spaces. Each packet number space
starts at packet number 0. Subsequent packets sent in the
same packet number space MUST increase the packet number by at least one.
This enforces cryptographic separation between the data sent in the different
packet sequence number spaces. Each packet number space starts at packet number
0. Subsequent packets sent in the same packet number space MUST increase the
packet number by at least one.

0-RTT and 1-RTT data exist in the same packet number space to make loss recovery
algorithms easier to implement between the two packet types.
Expand Down