New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge ACK and ACK_ECN #1801
Merged
Merged
Merge ACK and ACK_ECN #1801
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
bb364d6
Merge ACK and ACK_ECN
ianswett c7e3e10
Update draft-ietf-quic-transport.md
ianswett ddd62cb
Update draft-ietf-quic-transport.md
ianswett bd85b7b
Update draft-ietf-quic-transport.md
ianswett 09e9db0
Update draft-ietf-quic-transport.md
ianswett 0d14b5c
Update draft-ietf-quic-transport.md
ianswett 12a4d9a
Update draft-ietf-quic-transport.md
ianswett 481260f
Update draft-ietf-quic-transport.md
ianswett 064b237
Update draft-ietf-quic-transport.md
ianswett da050dd
Update draft-ietf-quic-transport.md
ianswett a5b115d
Update draft-ietf-quic-transport.md
ianswett File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3375,7 +3375,7 @@ Application Error Code: | |
|
||
Receivers send ACK frames (types=0x1a - 0x1b) to inform senders of packets they | ||
have received and processed. The ACK frame contains one or more ACK blocks. ACK | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. should we be capitalizing the B in ACK Blocks? |
||
blocks are ranges of acknowledged packets. If the frame types is 0x1b, ACK | ||
blocks are ranges of acknowledged packets. If the frame type is 0x1b, ACK | ||
frames also contain the sum of ECN marks received on the connection up until | ||
this point. | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(types 0x1a and 0x1b)