-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extended unidirectional streams can be closed or reset #2332
extended unidirectional streams can be closed or reset #2332
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is almost there. There is already some text recommending RESET_STREAM logic for push streams, which are not extensions (see section 4.2.4).
Perhaps we can generalise the statement?
Also typo a minor typo "s/torelate/tolerate"
@LPardue Do you have a specific suggestion re how we can generalize? My assumption has been that we cannot generalize, because control stream and QPACK streams can never be closed or reset. And thank you for catching the typo. Fixed that. |
Something like lose the first sentence and say instead "Some unidirectional stream types are allowed to be closed or reset during a connection. A receiver MUST tolerate unidirectional stream close or reset prior to reception of the type byte." Not sure my version is any better... |
@LPardue Thank you for the clarification. I agree that we should refrain from having a text that might seen as to imply that a push stream cannot be reset prior to sending the type byte. I've changed the approach to clarify the general rule (that the streams can be reset or closed) then name out the exceptions. Does that look better? |
Lgtm, thanks! |
Co-Authored-By: kazuho <kazuhooku@gmail.com>
Co-Authored-By: kazuho <kazuhooku@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Co-Authored-By: kazuho <kazuhooku@gmail.com>
closes #2331.