Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extended unidirectional streams can be closed or reset #2332

Conversation

kazuho
Copy link
Member

@kazuho kazuho commented Jan 13, 2019

closes #2331.

Copy link
Member

@LPardue LPardue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is almost there. There is already some text recommending RESET_STREAM logic for push streams, which are not extensions (see section 4.2.4).

Perhaps we can generalise the statement?

Also typo a minor typo "s/torelate/tolerate"

@kazuho
Copy link
Member Author

kazuho commented Jan 13, 2019

@LPardue Do you have a specific suggestion re how we can generalize? My assumption has been that we cannot generalize, because control stream and QPACK streams can never be closed or reset.

And thank you for catching the typo. Fixed that.

@LPardue
Copy link
Member

LPardue commented Jan 13, 2019

Something like lose the first sentence and say instead "Some unidirectional stream types are allowed to be closed or reset during a connection. A receiver MUST tolerate unidirectional stream close or reset prior to reception of the type byte."

Not sure my version is any better...

@kazuho
Copy link
Member Author

kazuho commented Jan 13, 2019

@LPardue Thank you for the clarification. I agree that we should refrain from having a text that might seen as to imply that a push stream cannot be reset prior to sending the type byte.

I've changed the approach to clarify the general rule (that the streams can be reset or closed) then name out the exceptions. Does that look better?

@LPardue
Copy link
Member

LPardue commented Jan 13, 2019

Lgtm, thanks!

draft-ietf-quic-http.md Outdated Show resolved Hide resolved
draft-ietf-quic-qpack.md Outdated Show resolved Hide resolved
martinthomson and others added 2 commits January 14, 2019 08:37
Co-Authored-By: kazuho <kazuhooku@gmail.com>
Co-Authored-By: kazuho <kazuhooku@gmail.com>
@MikeBishop MikeBishop added editorial An issue that does not affect the design of the protocol; does not require consensus. -http labels Jan 14, 2019
Copy link
Contributor

@MikeBishop MikeBishop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

draft-ietf-quic-http.md Outdated Show resolved Hide resolved
Co-Authored-By: kazuho <kazuhooku@gmail.com>
@MikeBishop MikeBishop merged commit 0fcb054 into quicwg:master Jan 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-http editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

What should the receiver do when the peer closes a unidirectional stream before providing the stream type?
4 participants