Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify kPersistentThreshold #2557

Merged
merged 3 commits into from
Mar 26, 2019
Merged

Simplify kPersistentThreshold #2557

merged 3 commits into from
Mar 26, 2019

Conversation

janaiyengar
Copy link
Contributor

This simplifies the definition of kPersistentThreshold from an exponent to a PTO multiplier.

@janaiyengar janaiyengar added editorial An issue that does not affect the design of the protocol; does not require consensus. -recovery labels Mar 26, 2019
Copy link
Contributor

@ianswett ianswett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but I think we need to move a lot of the rationale back into the normative text from the pseudocode. You can do that in this PR or as we resolve #2556

@janaiyengar
Copy link
Contributor Author

I think let's keep that separate. I think #2555 might end up with different outcomes anyways.

@janaiyengar janaiyengar merged commit 285d30a into master Mar 26, 2019
@janaiyengar janaiyengar deleted the jri/kpersistentthreshold branch May 22, 2019 09:35
@yangchi
Copy link

yangchi commented Jun 3, 2019

Curious, why wasn't this listed under draft-20 C.1? https://tools.ietf.org/html/draft-ietf-quic-recovery-20#appendix-C.1

@janaiyengar
Copy link
Contributor Author

janaiyengar commented Jun 6, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-recovery editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants