Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QPACK [editorial] Misc minor editorial changes. #2942

Merged
merged 9 commits into from
Oct 21, 2019
Merged

QPACK [editorial] Misc minor editorial changes. #2942

merged 9 commits into from
Oct 21, 2019

Conversation

bencebeky
Copy link
Contributor

No description provided.

@ianswett ianswett added the -qpack label Aug 2, 2019
MikeBishop
MikeBishop approved these changes Aug 16, 2019
View reviewed changes
Copy link
Contributor

@MikeBishop MikeBishop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nitpicks, but these are all good improvements. Thanks.

draft-ietf-quic-qpack.md Outdated Show resolved Hide resolved
draft-ietf-quic-qpack.md Show resolved Hide resolved
draft-ietf-quic-qpack.md Outdated Show resolved Hide resolved
draft-ietf-quic-qpack.md Show resolved Hide resolved
draft-ietf-quic-qpack.md Show resolved Hide resolved
draft-ietf-quic-qpack.md Outdated Show resolved Hide resolved
bencebeky
bencebeky commented Aug 19, 2019
View reviewed changes
Copy link
Contributor Author

@bencebeky bencebeky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the review.

draft-ietf-quic-qpack.md Outdated Show resolved Hide resolved
draft-ietf-quic-qpack.md Outdated Show resolved Hide resolved
draft-ietf-quic-qpack.md Outdated Show resolved Hide resolved
draft-ietf-quic-qpack.md Show resolved Hide resolved
bencebeky and others added 2 commits August 19, 2019 10:50
@bencebeky @MikeBishop
Apply suggestions from code review
0ca3bf7 
Co-Authored-By: Mike Bishop <mbishop@evequefou.be>
@bnc-google
MikeBishop's wording suggestion for allowing creation of an encoder s…
d29333e 
…tream and a decoder stream.
@bencebeky bencebeky mentioned this pull request Oct 8, 2019
Closed
afrind
afrind reviewed Oct 15, 2019
View reviewed changes
draft-ietf-quic-qpack.md Outdated Show resolved Hide resolved
draft-ietf-quic-qpack.md Outdated Show resolved Hide resolved
draft-ietf-quic-qpack.md Outdated Show resolved Hide resolved
draft-ietf-quic-qpack.md Show resolved Hide resolved
draft-ietf-quic-qpack.md Outdated Show resolved Hide resolved
@afrind afrind merged commit a38c07a into quicwg:master Oct 21, 2019
@bencebeky bencebeky deleted the bencebeky-qpack-minor-editorial branch October 22, 2019 17:02
@bencebeky bencebeky mentioned this pull request Oct 22, 2019
Merged
afrind pushed a commit that referenced this pull request Oct 29, 2019
@bnc-google @afrind
Make language of representations consistent.
4cdea46 
This was inspired by the comment by afrind at
#2942 (comment).

For each representation, uniformly
* use the word "representation" in the first sentence;
* use the word "identifies" if it's a verbatim entry; "encodes" otherwise;
* identify relative versus post-base indexing in the first sentence;
* move drawing right after first sentence;
* use consistent language describing binary format.
@martinthomson martinthomson added the editorial An issue that does not affect the design of the protocol; does not require consensus. label Oct 31, 2019
fungchou pushed a commit to fungchou/google_quckhe_mirror that referenced this pull request Mar 24, 2021
@bnc-google
Update language in QpackDecoder.
5443569 
Compressed field sections (formerly known as header blocks) consist of
"representations", not "instructions".  Also see
quicwg/base-drafts#2942 (comment).

PiperOrigin-RevId: 363015914
Change-Id: Ic113565211cc5234be9832e76c7cf025242b7a4f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtikhonov dtikhonov dtikhonov left review comments

@afrind afrind afrind left review comments

@MikeBishop MikeBishop MikeBishop approved these changes

Assignees
No one assigned
Labels
-qpack editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@bencebeky @MikeBishop @dtikhonov @afrind @martinthomson @ianswett @bnc-google