Make language of representations consistent. #3133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was inspired by the comment by afrind at #2942 (comment). For each representation, uniformly * use the word "representation" in the first sentence; * use the word "identifies" if it's a verbatim entry; "encodes" otherwise; * identify relative versus post-base indexing in the first sentence; * move drawing right after first sentence; * use consistent language describing binary format.
MikeBishop
approved these changes
Oct 28, 2019
afrind
reviewed
Oct 29, 2019
afrind
pushed a commit
that referenced
this pull request
Jan 21, 2020
This change has been suggested by afrind at #3133 (comment) on the basis that the Base is a count, and comparing an index to a count feels awkward.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was inspired by the comment by afrind at
#2942 (comment).
For each representation, uniformly