Update Stream Commitment Attack example #2965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Stream Commitment Attack part was added in draft-ietf-quic-transport-03, when unidirectional streams were not used. In draft-ietf-quic-transport-08, streams were split into unidirectional and bidirectional, but this example of stream commitment attack was missed.
marten-seemann
approved these changes
Aug 12, 2019
draft-ietf-quic-transport.md
Outdated
| @@ -5509,7 +5509,7 @@ However, when several streams are initiated at short intervals, transmission | |||
| error may cause STREAM DATA frames opening streams to be received out of | |||
There was a problem hiding this comment.
s/STREAM DATA frames/STREAM frames/
draft-ietf-quic-transport.md
Outdated
| sequence. A receiver is obligated to open intervening streams if a | ||
| higher-numbered stream ID is received. Thus, on a new connection, opening | ||
| stream 2000001 opens 1 million streams, as required by the specification. | ||
| stream 4000000 opens 1 million streams, as required by the specification. |
There was a problem hiding this comment.
1 million and 1, to be precise ;)
janaiyengar
added
-transport
editorial
|
Thanks, @tandf! I've done some editorializing, and merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Stream Commitment Attack part was added in draft-ietf-quic-transport-03, when unidirectional streams were not used.
In draft-ietf-quic-transport-08, streams were split into unidirectional and bidirectional, but this example of stream commitment attack was missed.