forbid empty NEW_TOKEN frames #2977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinthomson
added
-transport
editorial
Closed
kazuho
approved these changes
Aug 23, 2019
ianswett
approved these changes
Aug 23, 2019
draft-ietf-quic-transport.md
Outdated
| @@ -4843,7 +4843,8 @@ Token Length: | |||
|
|
|||
| Token: | |||
|
|
|||
| : An opaque blob that the client may use with a future Initial packet. | |||
| : An opaque blob that the client may use with a future Initial packet. The token | |||
| MUST NOT be empty. | |||
There was a problem hiding this comment.
Did you want to specify the connection close error to use if it's empty?
There was a problem hiding this comment.
I'd use a FRAME_ENCODING_ERROR error here. However, for other invalid frame errors we use PROTOCOL_VIOLATION. Not sure if that's something we want to address at some point.
|
Like @ianswett, I would like the spec to specify the error code. I don't care which it is. |
|
Consensus was declared on this PR a couple of days ago. Can we get this merged, and deal with the error code requested by @ianswett and @martinduke as part of #3027? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2978.
If we allow empty NEW_TOKEN frames, the receiver would have to check that the token is not empty before saving and reusing it, so it seems slightly easier to forbid this nonsensical edge case.