Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use contains() in recovery pseudocode #3015

Merged
merged 1 commit into from
Sep 10, 2019
Merged

Use contains() in recovery pseudocode #3015

merged 1 commit into from
Sep 10, 2019

Conversation

ianswett
Copy link
Contributor

Per @martinthomson suggestion, use contains() instead of the implicit check.

Fixes #2569
An alternative to #2987

@ianswett
Use contains()
7daa646 
Per @martinthomson suggestion, use contains() instead of the implicit check.

Fixes #2569 
An alternative to #2987
@ianswett ianswett added editorial An issue that does not affect the design of the protocol; does not require consensus. -recovery labels Sep 10, 2019
@ianswett ianswett mentioned this pull request Sep 10, 2019
Closed
janaiyengar
janaiyengar approved these changes Sep 10, 2019
View reviewed changes
Copy link
Contributor

@janaiyengar janaiyengar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this better.

@ianswett ianswett merged commit a6a7203 into master Sep 10, 2019
@ianswett ianswett deleted the ianswett-use-contains branch September 10, 2019 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janaiyengar janaiyengar janaiyengar approved these changes

@martinthomson martinthomson Awaiting requested review from martinthomson

Assignees
No one assigned
Labels
-recovery editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RTT sample should be taken only once for each largest_acked
2 participants
@ianswett @janaiyengar