-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Talk about concurrency in H3 vs. H2 #3114
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -1814,6 +1814,22 @@ considerations about exhaustion of stream identifier space apply, though the | |||||
space is significantly larger such that it is likely that other limits in QUIC | ||||||
are reached first, such as the limit on the connection flow control window. | ||||||
|
||||||
In contrast to HTTP/2, stream concurrency in HTTP/3 is managed by QUIC. QUIC | ||||||
considers a stream closed when all data has been received and sent data has been | ||||||
acknowledged by the peer. HTTP/2 considers a stream closed when the frame | ||||||
containing the END_STREAM bit has been committed to the transport. As a result, | ||||||
the stream for an equivalent exchange will typically remain "active" for one | ||||||
additional round trip. HTTP/3 servers might choose to permit a larger number of | ||||||
concurrent client-initiated bidirectional streams to achieve equivalent | ||||||
concurrency than were permitted in HTTP/2, depending on the expected usage | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. "permit a larger number...than were permitted" makes sense, but there are so many words between them that it's kind of hard to parse. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
patterns. | ||||||
|
||||||
Due to the presence of other unidirectional stream types, HTTP/3 does not rely | ||||||
exclusively on the number of concurrent unidirectional streams to control the | ||||||
number of concurrent in-flight pushes. Instead, HTTP/3 clients use the | ||||||
MAX_PUSH_ID frame to control the number of pushes received from an HTTP/3 | ||||||
server. | ||||||
|
||||||
## HTTP Frame Types {#h2-frames} | ||||||
|
||||||
Many framing concepts from HTTP/2 can be elided on QUIC, because the transport | ||||||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this sentence is incorrect.
I think it should be: "QUIC considers a stream closed when all data have been received and all the sent data have been acknowledged."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or a reset has been sent and acknowledged.