Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit linkages for ODCID/OCID TP #3149

Merged
merged 1 commit into from Oct 29, 2019
Merged

Conversation

MikeBishop
Copy link
Contributor

Fixes #2926.

@MikeBishop MikeBishop added editorial An issue that does not affect the design of the protocol; does not require consensus. -transport labels Oct 24, 2019
@MikeBishop
Copy link
Contributor Author

Note that #3120 may want to change the phrasing of the ODCID field, depending on which PR lands first.

Copy link
Member

@martinthomson martinthomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a conflict imminent here.

a Retry packet.
sent by the client. This transport parameter is only sent by a server. This
is the same value sent in the "Original Destination Connection ID" field of a
Retry packet (see {{packet-retry}}). A server MUST include the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that David's proposal for integrity protection of the Retry packet changes this text to point to the original Initial sent by the client. You should probably do the same.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you point to the specific text you're looking at?

David's text in #3120:

value of the Destination Connection ID from the Initial packet that this Retry is in response to.

Text here:

value of the Destination Connection ID field from the first Initial packet sent by the client

These seem to indicate the same Initial packet.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might have misremembered, sorry. In #3120, the text I was concerned about was

If the server sends a Retry packet, it MUST include the Destination Connection ID field from the client's first Initial packet in the transport parameter.

But you didn't touch that.

a Retry packet.
sent by the client. This transport parameter is only sent by a server. This
is the same value sent in the "Original Destination Connection ID" field of a
Retry packet (see {{packet-retry}}). A server MUST include the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might have misremembered, sorry. In #3120, the text I was concerned about was

If the server sends a Retry packet, it MUST include the Destination Connection ID field from the client's first Initial packet in the transport parameter.

But you didn't touch that.

@martinthomson martinthomson merged commit 6e803f1 into master Oct 29, 2019
@martinthomson martinthomson deleted the transport/name_connections branch October 29, 2019 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-transport editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ICID or OCID?
2 participants