Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicit linkages for ODCID/OCID TP #3149

Merged
merged 1 commit into from Oct 29, 2019
Merged

Explicit linkages for ODCID/OCID TP #3149

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 8 additions & 6 deletions draft-ietf-quic-transport.md
View file
Open in desktop
Expand Up @@ -4412,9 +4412,10 @@ The following transport parameters are defined:
original_connection_id (0x0000):

: The value of the Destination Connection ID field from the first Initial packet
sent by the client. This transport parameter is only sent by a server. A
server MUST include the original_connection_id transport parameter if it sent
a Retry packet.
sent by the client. This transport parameter is only sent by a server. This
is the same value sent in the "Original Destination Connection ID" field of a
Retry packet (see {{packet-retry}}). A server MUST include the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that David's proposal for integrity protection of the Retry packet changes this text to point to the original Initial sent by the client. You should probably do the same.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you point to the specific text you're looking at?

David's text in #3120:

value of the Destination Connection ID from the Initial packet that this Retry is in response to.

Text here:

value of the Destination Connection ID field from the first Initial packet sent by the client

These seem to indicate the same Initial packet.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might have misremembered, sorry. In #3120, the text I was concerned about was

If the server sends a Retry packet, it MUST include the Destination Connection ID field from the client's first Initial packet in the transport parameter.

But you didn't touch that.

original_connection_id transport parameter if it sent a Retry packet.

idle_timeout (0x0001):

Expand Down Expand Up @@ -4555,9 +4556,10 @@ initial_max_stream_data_uni) are equivalent to sending a MAX_STREAM_DATA frame
immediately after opening. If the transport parameter is absent, streams of
that type start with a flow control limit of 0.

A client MUST NOT include an original connection ID, a stateless reset token, or
a preferred address. A server MUST treat receipt of any of these transport
parameters as a connection error of type TRANSPORT_PARAMETER_ERROR.
A client MUST NOT include server-only transport parameters
(original_connection_id, stateless_reset_token, or preferred_address). A server
MUST treat receipt of any of these transport parameters as a connection error of
type TRANSPORT_PARAMETER_ERROR.


# Frame Types and Formats {#frame-formats}
Expand Down