Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify conditions for disabling spin bit #3296

Merged
merged 3 commits into from Jan 7, 2020
Merged

Clarify conditions for disabling spin bit #3296

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ac52e0f
Clarify the fractions of connections an endpoint must disable spin bi…
igorlord Nov 20, 2019
8ebd3bb
Disable spin randomly per-path or per-CID
martinthomson Dec 11, 2019
ee7d696
Jana strikes again with a solid suggestion
martinthomson Dec 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 5 additions & 6 deletions draft-ietf-quic-transport.md
View file
Open in desktop
Expand Up @@ -4380,12 +4380,11 @@ support the spin bit MUST implement it as specified in this section.
Each endpoint unilaterally decides if the spin bit is enabled or disabled for a
connection. Implementations MUST allow administrators of clients and servers
to disable the spin bit either globally or on a per-connection basis. Even when
the spin bit is not disabled by the administrator, implementations MUST disable
the spin bit for a given connection with a certain likelihood. The random
selection process SHOULD be designed such that on average the spin bit is
disabled for at least one eighth of network paths. The selection process
performed at the beginning of the connection SHOULD be applied for all paths
used by the connection.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the last sentence being dropped in the updated text. Is that intentional?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it seems to be duplicative as the text now talks about paths rather than connections.

the spin bit is not disabled by the administrator, endpoints MUST disable their
use of the spin bit for a random selection of at least one in every 16 network
paths, or for one in every 16 connection IDs. As each endpoint disables the
spin bit independently, this ensures that the spin bit signal is disabled on
approximately one in eight network paths.

When the spin bit is disabled, endpoints MAY set the spin bit to any value, and
MUST ignore any incoming value. It is RECOMMENDED that endpoints set the spin
Expand Down