Clarify conditions for disabling spin bit #3296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinthomson
added
editorial
kazuho
approved these changes
Dec 11, 2019
kazuho
reviewed
Dec 11, 2019
| selection process SHOULD be designed such that on average the spin bit is | ||
| disabled for at least one eighth of network paths. The selection process | ||
| performed at the beginning of the connection SHOULD be applied for all paths | ||
| used by the connection. |
There was a problem hiding this comment.
I see the last sentence being dropped in the updated text. Is that intentional?
There was a problem hiding this comment.
Yeah, it seems to be duplicative as the text now talks about paths rather than connections.
ianswett
approved these changes
Dec 11, 2019
janaiyengar
approved these changes
Dec 11, 2019
draft-ietf-quic-transport.md
Outdated
| used by the connection. | ||
| the spin bit is not disabled by the administrator, endpoints MUST disable their | ||
| use of the spin bit for a random selection of at least one in every 16 network | ||
| paths, or for one in every 16 connection IDs. This ensures that the spin bit |
There was a problem hiding this comment.
Suggested change
| paths, or for one in every 16 connection IDs. This ensures that the spin bit | |
| paths, or for one in every 16 connection IDs. Since both endpoints in a connection disable the spin bit independently, this ensures that the spin bit |
marten-seemann
approved these changes
Dec 11, 2019
igorlord
approved these changes
Dec 12, 2019
There was a problem hiding this comment.
Looks good technically. It may be slightly confusing, though, that the last sentence only talks about paths, while a sentence before talks about "paths or connection IDs". In any case, the behavior ensures a sufficient amount of traffic without the spin bit to prevent ossification of the bit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on #3270 to address the linkability issues that it added. It recommends 1/16 of network paths are disabled randomly as suggested by @kazuho. It also allows the determination to be made per connection ID rather than per-path (which is more granular, but I expect it will have a nearly identical effect). The net effect is that 1/8 paths will not spin as originally intended.
Closes #3270.
Closes #3257.
Closes #2628.