Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small clarification and one nit (recovery) #3392

Closed
wants to merge 1 commit into from
Closed

Small clarification and one nit (recovery) #3392

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions draft-ietf-quic-recovery.md
View file
Open in desktop
Expand Up @@ -467,14 +467,14 @@ Handshake packet number spaces, the max_ack_delay is 0, as specified in
The PTO value MUST be set to at least kGranularity, to avoid the timer expiring
immediately.

A sender computes its PTO timer every time an ack-eliciting packet is sent.
A sender resets its PTO timer every time an ack-eliciting packet is sent.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think computes is more accurate in this case, because the timer may not change if another packet number space will fire earlier.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a quick read it's actually not clear from the beginning that there is only one timer and not a separate timer for each packet. So maybe "recomputes" catches that? Or we could add a separate (half-)sentence.

Copy link
Contributor

@ianswett ianswett Mar 11, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTO timer is singular and associated with a sender, so it seems clear there's only one based on my reading. But feel free to suggest something else.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pulled this into #3552 with some tweaks, PTAL.

When ack-eliciting packets are in-flight in multiple packet number spaces,
the timer MUST be set for the packet number space with the earliest timeout,
except for ApplicationData, which MUST be ignored until the handshake
completes; see Section 4.1.1 of {{QUIC-TLS}}. Not arming the PTO for
ApplicationData prioritizes completing the handshake and prevents the server
from sending a 1-RTT packet on a PTO before before it has the keys to process
a 1-RTT packet.
from sending a 1-RTT packet on a PTO before it has the keys to process a 1-RTT
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, fixed in #3486 that landed today.

packet.

When a PTO timer expires, the PTO period MUST be set to twice its current
value. This exponential reduction in the sender's rate is important because
Expand Down