Clarify not arming PTO for ApplicationData before completion #3486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarifies exactly what the implications of not arming PTO for ApplicationData prior to handshake complete. This came from a discussion with a coworker who read the transport and recovery drafts, but not TLS.
ianswett
added
editorial
martinduke
suggested changes
Feb 28, 2020
draft-ietf-quic-recovery.md
Outdated
| ApplicationData prioritizes completing the handshake and prevents the server | ||
| from sending a 1-RTT packet on a PTO before before it has the keys to process | ||
| a 1-RTT packet. | ||
| ApplicationData prioritizes completing the handshake and prevents the client |
There was a problem hiding this comment.
Just to clarify a bit more and clean up the run-on sentence.
ApplicationData prioritizes completing the handshake, prevents the client
from sending a 0-RTT packet on a PTO before it knows the server has accepted
0-RTT, and prevents the server from sending a 1-RTT packet on a PTO before
before it has the keys to process a 1-RTT acknowledgment.
martinduke
approved these changes
Feb 28, 2020
yangfanud
reviewed
Feb 28, 2020
draft-ietf-quic-recovery.md
Outdated
| ApplicationData prioritizes completing the handshake, prevents the client | ||
| from sending a 0-RTT packet on a PTO before it knows the server has accepted | ||
| 0-RTT, and prevents the server from sending a 1-RTT packet on a PTO before | ||
| before it has the keys to process a 1-RTT acknowledgment. |
|
Thanks! I think this is much clearer from implementation perspective. |
marten-seemann
approved these changes
Feb 28, 2020
janaiyengar
reviewed
Feb 28, 2020
draft-ietf-quic-recovery.md
Outdated
Comment on lines
479
to
482
| ApplicationData prioritizes completing the handshake, prevents the client | ||
| from sending a 0-RTT packet on a PTO before it knows the server has accepted | ||
| 0-RTT, and prevents the server from sending a 1-RTT packet on a PTO before | ||
| it has the keys to process a 1-RTT acknowledgment. |
There was a problem hiding this comment.
Suggested change
| ApplicationData prioritizes completing the handshake, prevents the client | |
| from sending a 0-RTT packet on a PTO before it knows the server has accepted | |
| 0-RTT, and prevents the server from sending a 1-RTT packet on a PTO before | |
| it has the keys to process a 1-RTT acknowledgment. | |
| ApplicationData prioritizes completing the handshake, prevents a client from | |
| retransmitting a 0-RTT packet on a PTO expiration before confirming that the | |
| server is able to decrypt 0-RTT packets, and prevents a server from sending | |
| a 1-RTT packet on a PTO expiration before it has the keys to process an | |
| acknowledgement received in a 1-RTT packet. |
There was a problem hiding this comment.
That is a very long sentence.
Co-Authored-By: Martin Thomson <mt@lowentropy.net>
Comment on lines
+479
to
+482
| ApplicationData prevents a client from retransmitting a 0-RTT packet on a PTO | ||
| expiration before confirming that the server is able to decrypt 0-RTT packets, | ||
| and prevents a server from sending a 1-RTT packet on a PTO expiration before it | ||
| has the keys to process an acknowledgement. |
There was a problem hiding this comment.
Not arming the PTO for
Suggested change
| ApplicationData prevents a client from retransmitting a 0-RTT packet on a PTO | |
| expiration before confirming that the server is able to decrypt 0-RTT packets, | |
| and prevents a server from sending a 1-RTT packet on a PTO expiration before it | |
| has the keys to process an acknowledgement. | |
| ApplicationData prevents a client from sending a packet on PTO unless the server | |
| is able to acknowledge the packet. |
janaiyengar
reviewed
Mar 10, 2020
Comment on lines
+479
to
+482
| ApplicationData prevents a client from retransmitting a 0-RTT packet on a PTO | ||
| expiration before confirming that the server is able to decrypt 0-RTT packets, | ||
| and prevents a server from sending a 1-RTT packet on a PTO expiration before it | ||
| has the keys to process an acknowledgement. |
There was a problem hiding this comment.
Suggested change
| ApplicationData prevents a client from retransmitting a 0-RTT packet on a PTO | |
| expiration before confirming that the server is able to decrypt 0-RTT packets, | |
| and prevents a server from sending a 1-RTT packet on a PTO expiration before it | |
| has the keys to process an acknowledgement. | |
| ApplicationData prevents a client from sending a packet on PTO where there is uncertainty about the ability of the server to acknowledge the packet. This can happen before a client confirms that the server is able to decrypt 0-RTT packets, and also at a server before it has the keys to process an acknowledgement. |
There was a problem hiding this comment.
This isn't only about the server acknowledging packets, so I think this isn't quite correct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarifies exactly what the implications of not arming PTO for ApplicationData prior to handshake complete.
This came from a discussion with a coworker who read the transport and recovery drafts, but not TLS.