Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idle timeout editorial fixes #3444

Merged
merged 2 commits into from
Feb 22, 2020
Merged

Conversation

ianswett
Copy link
Contributor

@ianswett ianswett commented Feb 9, 2020

From @janaiyengar and @MikeBishop comments on #3099

Fixes #3184

@ianswett ianswett added editorial An issue that does not affect the design of the protocol; does not require consensus. -transport labels Feb 9, 2020
Copy link
Member

@martinthomson martinthomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that the shift in the explanation misses the important point for a lesser one.

and processed successfully. The idle timer is also restarted when sending the
first ack-eliciting packet (see {{QUIC-RECOVERY}}) after receiving a packet.
Only restarting when sending after receipt of a packet ensures the idle timeout
is not excessively lengthened past the time the peer's timeout has expired.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sentence doesn't really capture what the original text was attempting to explain. That is, the original text intended to explain that a reset on receipt is insufficient because local attempts to restart communication might still result in the idle timeout period lapsing. This says something different.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the change is in response to my comment, that you also need to clarify why it's not sufficient to reset it on every packet you send. Basically, we've chosen a more complicated condition than "on receive" or "on send," and we should justify why the simpler conditions don't work.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I added back the original sentence, since as you point out, something was lost. PTAL.

out when initiating new activity. Only restarting when sending after receipt of
a packet ensures the idle timeout is not excessively lengthened past the time
the peer's timeout has expired. An endpoint might need to send packets to avoid
an idle timeout if it is unable to send application data due to being blocked on
flow control limits; see {{flow-control}}.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps clarify that it is the application that decides when to keep a connection alive.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's only true to the extent that the application controls what activity is generated. An application needs to communicate its intent.

@martinthomson martinthomson merged commit 6e13a0b into master Feb 22, 2020
@martinthomson martinthomson deleted the ianswett-idle-timeout-editorial branch February 22, 2020 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-transport editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the idle timeout text
4 participants