Add stream offset limit of 2^64. #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianswett
reviewed
Feb 28, 2017
draft-ietf-quic-transport.md
Outdated
| @@ -1182,7 +1182,8 @@ The STREAM frame contains the following fields: | |||
|
|
|||
| * Offset: A variable-sized unsigned number specifying the byte offset in the | |||
| stream for the data in this STREAM frame. The first byte in the stream has an | |||
| offset of 0. | |||
| offset of 0. The largest offset delivered on a stream---the sum of the | |||
| re-constructed offset and data length---MUST be lesser than 2^64. | |||
There was a problem hiding this comment.
lesser than -> less than, here and below?
draft-ietf-quic-transport.md
Outdated
| as an ordered byte-stream. Data received out of order MUST be buffered for | ||
| later delivery, as long as it is not in violation of the receiver's flow control | ||
| The largest offset delivered on a stream MUST be lesser than 2^64. A receiver | ||
| MUST ensure that received stream data is delivered to the application as an |
There was a problem hiding this comment.
nit: How about "MUST ensure that received stream data is available to the application as an ordered byte-stream."
draft-ietf-quic-transport.md
Outdated
| @@ -1182,7 +1182,8 @@ The STREAM frame contains the following fields: | |||
|
|
|||
| * Offset: A variable-sized unsigned number specifying the byte offset in the | |||
| stream for the data in this STREAM frame. The first byte in the stream has an | |||
| offset of 0. | |||
| offset of 0. The largest offset delivered on a stream---the sum of the | |||
| re-constructed offset and data length---MUST be lesser than 2^64. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.