Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add stream offset limit of 2^64. #350

Merged
merged 2 commits into from
Mar 3, 2017
Merged

Add stream offset limit of 2^64. #350

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
12ef694
Add stream offset limit.
Feb 28, 2017
3d9d177
Correct typographic errors
martinthomson Mar 2, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions draft-ietf-quic-transport.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1182,7 +1182,8 @@ The STREAM frame contains the following fields:

* Offset: A variable-sized unsigned number specifying the byte offset in the
stream for the data in this STREAM frame. The first byte in the stream has an
offset of 0.
offset of 0. The largest offset delivered on a stream---the sum of the
re-constructed offset and data length---MUST be lesser than 2^64.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lesser than -> less than, here and below?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: don't use ---


* Stream Data: The bytes from the designated stream to be delivered.

Expand Down Expand Up @@ -1962,9 +1963,10 @@ sender or during delivery to the application at the receiver.
When new data is to be sent on a stream, a sender MUST set the encapsulating
STREAM frame's offset field to the stream offset of the first byte of this new
data. The first byte of data that is sent on a stream has the stream offset 0.
A receiver MUST ensure that received stream data is delivered to the application
as an ordered byte-stream. Data received out of order MUST be buffered for
later delivery, as long as it is not in violation of the receiver's flow control
The largest offset delivered on a stream MUST be lesser than 2^64. A receiver
MUST ensure that received stream data is delivered to the application as an
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: How about "MUST ensure that received stream data is available to the application as an ordered byte-stream."

ordered byte-stream. Data received out of order MUST be buffered for later
delivery, as long as it is not in violation of the receiver's flow control
limits.

The cryptographic handshake stream, Stream 1, MUST NOT be subject to congestion
Expand Down