eliminate the difference between when having no RTT sample and having one #3525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianswett
reviewed
Mar 16, 2020
|
@ianswett Thank you for the review. Would you ming checking if the updated text has what you have suggested? |
ianswett
approved these changes
Mar 16, 2020
ianswett
added
the
editorial
Co-Authored-By: ianswett <ianswett@users.noreply.github.com>
ianswett
approved these changes
Mar 16, 2020
janaiyengar
approved these changes
Mar 17, 2020
There was a problem hiding this comment.
Thank you, @kazuho, this is a good fix. This also fixes the case where the 2 x initialRtt is smaller than granularity.
janaiyengar
removed
the
editorial
ianswett
added
the
design
Co-Authored-By: Jana Iyengar <jri.ietf@gmail.com>
janaiyengar
approved these changes
Mar 18, 2020
Co-Authored-By: Jana Iyengar <jri.ietf@gmail.com>
ianswett
approved these changes
Mar 21, 2020
Co-Authored-By: Jana Iyengar <jri.ietf@gmail.com>
Co-Authored-By: Jana Iyengar <jri.ietf@gmail.com>
|
@janaiyengar @ianswett Thank you for the suggestions. I've applied them. |
janaiyengar
approved these changes
Mar 31, 2020
There was a problem hiding this comment.
LGTM - thanks, @kazuho! Can you resolve the merge conflict?
ianswett
approved these changes
Mar 31, 2020
This was referenced Jul 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out in #3524, I think that we should assume same amount of RTT variance when there is no RTT sample and when there is one sample, because variance is unknown in both cases.
This PR makes that change while keeping the initial PTO being the same (i.e. 1 second), and slightly simplifies the timeout logic.
Fixes #3524.