Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notify the congestion controller of losses first #3540

Merged
merged 19 commits into from
Apr 1, 2020
Merged

Notify the congestion controller of losses first #3540

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
6290d14
Notify the congestion controller of losses first
ianswett Mar 22, 2020
0c944ea
Update draft-ietf-quic-recovery.md
ianswett Mar 22, 2020
5f520e2
temp update
ianswett Mar 29, 2020
de8eca5
Update draft-ietf-quic-recovery.md
ianswett Mar 29, 2020
2594cd1
Update draft-ietf-quic-recovery.md
ianswett Mar 29, 2020
05d9705
Update draft-ietf-quic-recovery.md
ianswett Mar 29, 2020
902703f
Update draft-ietf-quic-recovery.md
ianswett Mar 30, 2020
35fad6f
Update draft-ietf-quic-recovery.md
ianswett Mar 31, 2020
71bebc7
Update draft-ietf-quic-recovery.md
ianswett Mar 31, 2020
c942fd8
Update draft-ietf-quic-recovery.md
ianswett Mar 31, 2020
5d0f177
Apply suggestions from code review
ianswett Mar 31, 2020
ef5ea9c
Update draft-ietf-quic-recovery.md
ianswett Mar 31, 2020
949bbab
Update draft-ietf-quic-recovery.md
ianswett Mar 31, 2020
6c7ff3f
Update draft-ietf-quic-recovery.md
ianswett Mar 31, 2020
3634c6b
Apply suggestions from code review
ianswett Mar 31, 2020
2503587
Use largest() consistently
ianswett Mar 31, 2020
a90f17c
Update draft-ietf-quic-recovery.md
ianswett Mar 31, 2020
ae9bb47
Update draft-ietf-quic-recovery.md
ianswett Mar 31, 2020
b34f5f9
Update draft-ietf-quic-recovery.md
ianswett Apr 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions draft-ietf-quic-recovery.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1110,14 +1110,16 @@ OnAckReceived(ack, pn_space):

// DetectNewlyAckedPackets finds packets that are newly
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DetectNewlyAckedPackets is not defined in master.

// acknowledged and removes them from sent_packets.
newly_acked_packets = DetectAndRemoveAckedPackets(ack, pn_space)
newly_acked_packets =
DetectAndRemoveAckedPackets(ack, pn_space)
// Nothing to do if there are no newly acked packets.
if (newly_acked_packets.empty()):
return

// If the largest acknowledged is newly acked and
// at least one ack-eliciting was newly acked, update the RTT.
if (newly_acked_packets.largest().packet_number == ack.largest_acked &&
if (newly_acked_packets.largest().packet_number ==
ack.largest_acked &&
IncludesAckEliciting(newly_acked_packets)):
latest_rtt =
now - sent_packets[pn_space][ack.largest_acked].time_sent
Expand Down Expand Up @@ -1483,8 +1485,8 @@ Invoked from DetectLostPackets when packets are deemed lost.
max_ack_delay
congestion_period = pto * kPersistentCongestionThreshold
// Determine if all packets in the time period before the
// largest newly lost packet, including the edges, are marked
// lost
// largest newly lost packet, including the edges, are
// marked lost
return AreAllPacketsLost(lost_packets, congestion_period)

OnPacketsLost(lost_packets):
Expand Down