Clarify the Timestamps section #360
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
draft-ietf-quic-transport.md
Outdated
| @@ -1221,6 +1221,13 @@ Unlike TCP SACKs, QUIC ACK blocks are cumulative and therefore irrevocable. | |||
| Once a packet has been acknowledged, even if it does not appear in a future ACK | |||
| frame, it is assumed to be acknowledged. | |||
|
|
|||
| QUIC ack frames contain a timestamp section with up to 255 timestamps. | |||
|
Added a section to further clarify that Delta Last Acknowledged 1..N" is relative to the last acknowledged |
janaiyengar
reviewed
Mar 7, 2017
| @@ -1352,6 +1358,10 @@ receive times relative to the beginning of the connection. | |||
| ~~~ | |||
| {: #timestamp-format title="Timestamp Section"} | |||
|
|
|||
| The timestamp section is time-ordered, so the 1 byte Delta Largest | |||
| Acknowledged is always relative to the Largest Acknowleged, but the Time | |||
| Since Previous Timestamp fields are relative. | |||
There was a problem hiding this comment.
I would suggest moving this to below the descriptions of the fields. Suggested rewording: "The timestamp section lists packet receipt timestamps ordered by timestamp." I think you can drop the rest of this paragraph since it's redundant with text in the descriptions.
|
Rebased and merged manually. |
|
@ianswett, can you try to remember to name your branches in future. These branch names are going to collide with old patches (as this one already did, causing me some confusion). |
|
Sure, I'm happy to name them. I didn't realize it mattered. |
This was referenced Mar 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intends to resolve #308