Send a TLS alert when TLS encounters an error #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also rationalize the TLS error messages, which means removing most of them. Closes #272
|
Since we got both TLS and QUIC connections, I figured it might better to be clear about which one the sentence is referring to. Might be a bit over the to say add "TLS" before alert, but with it there's no ambiguity. |
seanturner
approved these changes
Mar 10, 2017
|
Thanks Sean. |
This was referenced Mar 10, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also rationalize the TLS error messages, which means removing most of them.
Closes #272