Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codify how handshake failures are written down #37

Closed
martinthomson opened this issue Nov 28, 2016 · 5 comments
Closed

Codify how handshake failures are written down #37

martinthomson opened this issue Nov 28, 2016 · 5 comments
Labels
-transport editorial An issue that does not affect the design of the protocol; does not require consensus.

Comments

@martinthomson
Copy link
Member

There's a bunch of places where we want to recommend that the handshake fails. We need an editorial convention for how to write that down, which should include any error codes and messages that are sent at the same time.

@martinthomson martinthomson added the editorial An issue that does not affect the design of the protocol; does not require consensus. label Nov 28, 2016
@martinthomson
Copy link
Member Author

@MikeBishop has already adopted the convention from HTTP/2 in #131.

"MUST be treated as a (connection|stream) error of type ."

We just need a section describing what a connection or stream error is. That belongs in the transport draft. We should wait for #131 before doing that though. We can close this issue when that is in place (not when every place we need an error code is fixed, that might take some time to work out properly).

@martinduke
Copy link
Contributor

Lastly, I'm not sure if this is a separate issue, but I would like to see some language here, or in the loss recovery document, about client actions when the first handshake message is lost. We have overloaded this loss signal with multiple meanings/responses:

(1) Retransmit (due to garden-variety network loss)
(2) Change MTU and retransmit (due to MTU problems, though we might see ICMP here?)
(3) Failover to TCP (middleboxes eating QUIC)
(4) Give up (path failure)

If I were implementing a client using these documents, I am not sure how I would handle a CHLO loss given these conflicting imperatives. I could accept having SHOULDs instead of MUSTs, but there ought to be something.

@ianswett
Copy link
Contributor

Agreed, that should be in there. I think that belongs in the loss recovery doc. Want to a file a specific issue to fix that, since it seems somewhat orthogonal to the type of handshake failure this issue was intended to discuss.

@martinduke
Copy link
Contributor

Will do.

@martinthomson
Copy link
Member Author

Closed by #374.

martinthomson pushed a commit that referenced this issue Jun 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-transport editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
None yet
Development

No branches or pull requests

3 participants