Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flow control accounting uses the maximum data offset on each stream #378

Merged
merged 2 commits into from Mar 10, 2017
Merged

Flow control accounting uses the maximum data offset on each stream #378

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1065da6
Flow control accounting uses the maximum data offset on each stream
martinthomson Mar 9, 2017
8248c50
Review comments
martinthomson Mar 10, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 6 additions & 6 deletions draft-ietf-quic-transport.md
View file
Open in desktop
Expand Up @@ -865,8 +865,8 @@ connection_fc_offset (0x0001):
of 1024 octets. That is, the value here is multiplied by 1024 to determine
the actual flow control offset. The sender of this parameter sets the byte
offset for connection level flow control to this value. This is equivalent to
sending a WINDOW_UPDATE ({{frame-window-update}}) for stream 0 immediately
after completing the handshake.
sending a WINDOW_UPDATE ({{frame-window-update}}) for the connection
immediately after completing the handshake.

concurrent_streams (0x0002):

Expand Down Expand Up @@ -1545,10 +1545,10 @@ The connection-level flow control offset is expressed in units of 1024 octets
offset is determined by multiplying the encoded value by 1024.

An endpoint accounts for the maximum offset of data that is sent or received on
a stream. Loss or reordering can mean that the size of STREAM frames can be
less than the maximum data offset on a stream; similarly, STREAM frames might
not cause the maximum offset on a stream. A STREAM frame with a FIN bit set or
RST_STREAM causes the final offset for a stream to be fixed.
a stream. Loss or reordering can mean that the maximum offset is greater than
the total size of data received on a stream. Similarly, receiving STREAM frames
might not increase the maximum offset on a stream. A STREAM frame with a FIN
bit set or RST_STREAM causes the final offset for a stream to be fixed.

The maximum data offset on a stream MUST NOT exceed the stream flow control
offset advertised by the receiver. The sum of the maximum data offsets of all
Expand Down