Editorial suggestions on TLS #3818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeBishop
added
editorial
martinthomson
approved these changes
Jul 3, 2020
| @@ -1110,7 +1112,7 @@ sample. | |||
| To ensure that sufficient data is available for sampling, packets are padded so | |||
| that the combined lengths of the encoded packet number and protected payload is | |||
| at least 4 bytes longer than the sample required for header protection. The | |||
| ciphersuites defined in {{?TLS13}} - other than TLS_AES_128_CCM_8_SHA256, for | |||
| cipher suites defined in {{!TLS13}} - other than TLS_AES_128_CCM_8_SHA256, for | |||
There was a problem hiding this comment.
I tend to use ? where the reference is normative.
If you follow this discipline and remove the last normative reference, the right thing happens. But I can't see that happening here, so this change is fine.
Co-authored-by: Martin Thomson <mt@lowentropy.net>
Co-authored-by: Martin Thomson <mt@lowentropy.net>
MikeBishop
force-pushed
the
tls/mbishop_wglc
branch
from
000a681
to
39e6b42
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe these are all editorial, but please review.