Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ack_delay in the first Handshake and 1RTT packet #3981

Closed
wants to merge 6 commits into from
Closed

ack_delay in the first Handshake and 1RTT packet #3981

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9090e42
ack_delay in the first Handshake and 1RTT packet
ianswett Aug 3, 2020
311d22d
Update draft-ietf-quic-transport.md
ianswett Aug 3, 2020
9ed9536
Update draft-ietf-quic-recovery.md
ianswett Aug 3, 2020
2226fe7
Update draft-ietf-quic-recovery.md
ianswett Aug 4, 2020
cb6f4c7
Update draft-ietf-quic-recovery.md
ianswett Aug 4, 2020
73ec359
Update draft-ietf-quic-recovery.md
ianswett Aug 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions draft-ietf-quic-recovery.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,11 +348,11 @@ latency at the peer or loss of previous ACK frames. Any delays beyond the
peer's max_ack_delay are therefore considered effectively part of path delay and
incorporated into the smoothed_rtt estimate.

The first ACK frame in the Handshake and ApplicationData packet number spaces can
be greatly delayed due to a lack of decryption keys at the time they're received.
For these two ACK frames, the max_ack_delay MAY be ignored if the sender chooses.
Note that if there are no prior RTT samples, ignoring max_ack_delay has no
impact.
The first ACK frame in the Handshake and ApplicationData packet number spaces
can be greatly delayed due to a lack of decryption keys at the time they're
received. For these two ACK frames, the max_ack_delay MAY be ignored if the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not really the first, but any packets that are buffered, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, though hopefully you're processing all buffered packets before sending an ACK.

sender chooses. If the delayed ACK frame is the first RTT sample, ignoring
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last sentence reads as imperative, but it's more of a "Note that if the delayed"

max_ack_delay has no impact.

When adjusting an RTT sample using peer-reported acknowledgement delays, an
endpoint:
Expand Down