Pseudocode for persistent congestion is too hard #4080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes that function, relying instead on comments and the definition in text (which people have noted is now very clear). I have also reset a couple of extra variables in this case. It is important to catch all of these because if you don't you get poor outcomes. The only question I have is regarding bytes in flight. I think that we need to keep tracking those bytes, or the overall accounting gets messy. That is what our implementation does anyway. Closes #4010. Closes #3972.
martinthomson
added
editorial
ianswett
approved these changes
Sep 8, 2020
ianswett
approved these changes
Sep 8, 2020
janaiyengar
approved these changes
Sep 8, 2020
|
@kazu-yamamoto : Please take a look. I'll merge this, but please respond with comments if you think something here should be changed. |
|
@janaiyengar This PR seems reasonable to me. I support this change. @martinthomson Thank you for brushing up the code. Since I'm a functional programmer, I prefer to use I don't understand your concern about "bytes in flight". |
|
Thanks @kazu-yamamoto, I share your preference for doing something like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes that function, relying instead on comments and the
definition in text (which people have noted is now very clear).
I have also reset a couple of extra variables in this case. It is
important to catch all of these because if you don't you get poor
outcomes.
The only question I have is regarding bytes in flight. I think that we
need to keep tracking those bytes, or the overall accounting gets messy.
That is what our implementation does anyway.
Closes #4010.
Closes #3972.