Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pseudocode for persistent congestion is too hard #4080

Merged
merged 8 commits into from
Sep 8, 2020
Merged

Pseudocode for persistent congestion is too hard #4080

Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
fb64708
Pseudocode for persistent congestion is too hard
martinthomson Sep 2, 2020
a8adc5d
oops
martinthomson Sep 8, 2020
779d923
Filter out packets sent before an RTT sample
martinthomson Sep 8, 2020
20642c9
Make a copy for this
martinthomson Sep 8, 2020
71c232f
Merge branch 'master' into no-pc-pseudocode
martinthomson Sep 8, 2020
c4bd59f
Copy inline
martinthomson Sep 8, 2020
9c2d7fb
curlies
martinthomson Sep 8, 2020
900535a
Invert comment
martinthomson Sep 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 4 additions & 15 deletions draft-ietf-quic-recovery.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1690,27 +1690,16 @@ ProcessECN(ack, pn_space):
Invoked when DetectAndRemoveLostPackets deems packets lost.

~~~
InPersistentCongestion(largest_lost):
// Persistent congestion cannot be declared on the
// first RTT sample.
if (is first RTT sample):
return false
pto = smoothed_rtt + max(4 * rttvar, kGranularity) +
max_ack_delay
congestion_period = pto * kPersistentCongestionThreshold
// Determine if all packets in the time period before the
// largest newly lost packet, including the edges and
// across all packet number spaces, are marked lost.
return AreAllPacketsLost(largest_lost, congestion_period)

OnPacketsLost(lost_packets):
// Remove lost packets from bytes_in_flight.
for lost_packet in lost_packets:
bytes_in_flight -= lost_packet.sent_bytes
OnCongestionEvent(lost_packets.largest().time_sent)
// Collapse congestion window if persistent congestion
if (InPersistentCongestion(lost_packets.largest())):
// Reset the congestion window if the loss of these
// packets indicates persistent congestion.
if (InPersistentCongestion(lost_packets)):
congestion_window = kMinimumWindow
congestion_recovery_start_time = 0
~~~

## Upon dropping Initial or Handshake keys
Expand Down