update refs for -12 of http core drafts #4182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeBishop
requested changes
Oct 7, 2020
draft-ietf-quic-http.md
Outdated
| @@ -459,8 +459,8 @@ An HTTP message (request or response) consists of: | |||
| 3. optionally, the trailer field section, if present, sent as a single HEADERS | |||
| frame. | |||
|
|
|||
| Header and trailer field sections are described in Section 5 of {{!SEMANTICS}}; | |||
| the payload body is described in Section 7.3.3 of {{!SEMANTICS}}. | |||
| Header and trailer field sections are described in Section 5.4 of {{!SEMANTICS}}; | |||
There was a problem hiding this comment.
Section 5.4 is about headers only, not trailers. This may need to explicitly reference 5.4 and 5.6 to get the equivalent context. Also, this paragraph will need to be rewrapped.
MikeBishop
reviewed
Oct 7, 2020
draft-ietf-quic-http.md
Outdated
| @@ -1773,7 +1773,7 @@ attack on a plaintext protocol. | |||
| ## Intermediary Encapsulation Attacks | |||
|
|
|||
| The HTTP/3 field encoding allows the expression of names that are not valid | |||
| field names in the syntax used by HTTP (Section 5.3 of {{!SEMANTICS}}). Requests | |||
| field names in the syntax used by HTTP (Section 5.4.3 of {{!SEMANTICS}}). Requests | |||
There was a problem hiding this comment.
This paragraph needs to be rewrapped.
|
@reschke could you please help us out by responding to Mike's comments. This PR you kindly made will help us address issues raised during AD review, which is a blocker to LC. |
martinthomson
added
-http
editorial
|
If @reschke isn't responding, @MikeBishop should use his best judgement and then merge this. |
|
I only did a mechanical check (restoring the references that were there before). @MikeBishop - if you feel that these can be improved just go ahead. |
MikeBishop
reviewed
Oct 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.