-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove mention of pipeACK #4190
Merged
Merged
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
d9ac648
Clarify that pipeACK is an example
ianswett e832f5d
Update draft-ietf-quic-recovery.md
ianswett 7bc0c7f
Update draft-ietf-quic-recovery.md
ianswett 606b7d2
Remove paragraph per mirja's suggestion
ianswett f61b2d0
Change references to 3168 to be normative
ianswett File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would actually rephrase this part completely (or maybe just remove it entirely as there is another reference two paragraphs down). RFC7661 mainly uses the term "application-limited", however, it does not really propose a mechanism to exactly detect that a connection is application-limited, but rather proposes additional mechanism to even decrease the congestion window when no validated. It further says that the cwnd window MUST NOT be increase when not cwnd-limited and that cwnd-limitation is detected based on FlightSize (or other mechanism, see also section 4.5.3 of RFC7661) as also described in the previous paragraph in the recovery draft:
So I don't think RFC7661 actually provides any different meachanism to detect if the cwnd is sufficiently utilised.
Please note also that RFC7661 actually says MUST NOT while the QUIC recovery draft has only a SHOULD NOT...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, I'll remove this paragraph.